Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra metadata option for selective version of property collection #734

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

andy-beer
Copy link
Contributor

This change adds an optional extra argument to the selective_version_of_collection() function, allowing extra metadata to play a role in property selection.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (01ab596) 80.92% compared to head (7c77ced) 80.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         190      190           
  Lines       32377    32384    +7     
=======================================
+ Hits        26200    26207    +7     
  Misses       6177     6177           
Impacted Files Coverage Δ
resqpy/property/property_collection.py 82.79% <ø> (ø)
resqpy/property/property_common.py 93.51% <ø> (ø)
resqpy/property/_collection_add_part.py 81.20% <100.00%> (+0.50%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andy-beer andy-beer merged commit 64faed0 into master Jun 27, 2023
10 checks passed
@andy-beer andy-beer deleted the prop_selection_with_em branch October 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant