Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for properties on Polyline, PolylineSet, and PointSet #736

Merged
merged 9 commits into from
Jun 28, 2023

Conversation

andy-beer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 91.78% and project coverage change: +0.02 🎉

Comparison is base (64faed0) 80.92% compared to head (90e6745) 80.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   80.92%   80.94%   +0.02%     
==========================================
  Files         190      190              
  Lines       32384    32452      +68     
==========================================
+ Hits        26206    26269      +63     
- Misses       6178     6183       +5     
Impacted Files Coverage Δ
resqpy/property/_collection_support.py 78.40% <25.00%> (-5.35%) ⬇️
resqpy/lines/_polyline.py 84.87% <100.00%> (+0.18%) ⬆️
resqpy/lines/_polyline_set.py 92.32% <100.00%> (+0.15%) ⬆️
resqpy/property/_collection_get_attributes.py 85.32% <100.00%> (+0.78%) ⬆️
resqpy/property/property_collection.py 82.93% <100.00%> (+0.13%) ⬆️
resqpy/surface/_pointset.py 86.82% <100.00%> (+0.61%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@emmanesbit emmanesbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good @andy-beer

@andy-beer andy-beer merged commit 525090c into master Jun 28, 2023
@andy-beer andy-beer deleted the polyline_properties branch October 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants