Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: New method to create and flange extended surface, avoiding retriangulation #862

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

emmanesbit
Copy link
Contributor

@emmanesbit emmanesbit commented Dec 6, 2024

New method allowing a surface to be generated based on an existing surface, with flange extended points. The new triangles and points are added directly, avoiding retriangulation.

@emmanesbit emmanesbit added the enhancement New feature or request label Dec 6, 2024
@emmanesbit emmanesbit requested a review from andy-beer December 6, 2024 10:42
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 87.95181% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (9a99e76) to head (a95951b).

Files with missing lines Patch % Lines
resqpy/surface/_surface.py 87.95% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   83.66%   83.67%           
=======================================
  Files         192      192           
  Lines       33636    33719   +83     
=======================================
+ Hits        28142    28214   +72     
- Misses       5494     5505   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant