Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grid_surface_mp.py to expose reorient argument #863

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

emmanesbit
Copy link
Contributor

Exposes the reorient argument (previously True) to allow user definition. Still defaults to True when not provided.

@emmanesbit emmanesbit added the enhancement New feature or request label Dec 10, 2024
@emmanesbit emmanesbit requested a review from andy-beer December 10, 2024 16:37
@emmanesbit emmanesbit self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (9a99e76) to head (e35c4b8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files         192      192           
  Lines       33636    33636           
=======================================
  Hits        28142    28142           
  Misses       5494     5494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmanesbit emmanesbit changed the title Draft: Update grid_surface_mp.py to expose reorient argument Update grid_surface_mp.py to expose reorient argument Dec 10, 2024
@andy-beer andy-beer merged commit 2c448c5 into master Dec 11, 2024
10 checks passed
@andy-beer andy-beer deleted the expose_reorient_arg branch December 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants