Trim terms same way while indexing and querying #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrice6713
approved these changes
Sep 1, 2022
brianluisgomez
approved these changes
Sep 1, 2022
bpateldx
requested review from
brianluisgomez and
ajrice6713
and removed request for
brianluisgomez
brianluisgomez
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
The
trimmeris only used at the time of indexing but not whilequerying. This results in an incorrect query generation and search does not work as expected, specifically if you're searching for a phrase/keyword with special characters in the beginning and/or at the end.Testing
Added E2E Tests. All Tests are passing