final cleanups

proxmox/access/users_types.go

@@ -14,7 +14,7 @@ type UserChangePasswordRequestBody struct {
 	Password string `json:"password" url:"password"`
 }
 
-// UserCreateRequestBody contains the data for an user create request.
+// UserCreateRequestBody contains the data for a user create request.
 type UserCreateRequestBody struct {
 	Comment        *string                `json:"comment,omitempty"   url:"comment,omitempty"`
 	Email          *string                `json:"email,omitempty"     url:"email,omitempty"`
@@ -28,7 +28,7 @@ type UserCreateRequestBody struct {
 	Password       string                 `json:"password"            url:"password"`
 }
 
-// UserGetResponseBody contains the body from an user get response.
+// UserGetResponseBody contains the body from a user get response.
 type UserGetResponseBody struct {
 	Data *UserGetResponseData `json:"data,omitempty"`
 }
@@ -45,7 +45,7 @@ type UserGetResponseData struct {
 	LastName       *string                `json:"lastname,omitempty"`
 }
 
-// UserListResponseBody contains the body from an user list response.
+// UserListResponseBody contains the body from a user list response.
 type UserListResponseBody struct {
 	Data []*UserListResponseData `json:"data,omitempty"`
 }

proxmox/client.go

@@ -37,8 +37,8 @@ type Client interface {
 	// Version returns a client for getting the version of the Proxmox Virtual Environment API.
 	Version() *version.Client
 
-	// REST returns a lower-lever REST API client.
-	REST() api.Client
+	// API returns a lower-lever REST API client.
+	API() api.Client
 
 	// SSH returns a lower-lever SSH client.
 	SSH() ssh.Client
@@ -84,8 +84,8 @@ func (c *client) Version() *version.Client {
 	return &version.Client{Client: c.a}
 }
 
-// REST returns a lower-lever REST API client.
-func (c *client) REST() api.Client {
+// API returns a lower-lever REST API client.
+func (c *client) API() api.Client {
 	return c.a
 }
 

proxmox/nodes/vms/vms_types.go

@@ -510,7 +510,7 @@ type GetStatusResponseData struct {
 	VMID             *int              `json:"vmid,omitempty"`
 }
 
-// ListResponseBody contains the body from an virtual machine list response.
+// ListResponseBody contains the body from a virtual machine list response.
 type ListResponseBody struct {
 	Data []*ListResponseData `json:"data,omitempty"`
 }

proxmox/pools/pool_types.go

@@ -23,7 +23,7 @@ type PoolGetResponseData struct {
 	Members []VirtualEnvironmentPoolGetResponseMembers `json:"members,omitempty"`
 }
 
-// VirtualEnvironmentPoolGetResponseMembers contains the members data from an pool get response.
+// VirtualEnvironmentPoolGetResponseMembers contains the members data from a pool get response.
 type VirtualEnvironmentPoolGetResponseMembers struct {
 	ID          string  `json:"id"`
 	Node        string  `json:"node"`

proxmoxtf/config.go

@@ -22,11 +22,11 @@ type ProviderConfiguration struct {
 
 // NewProviderConfiguration creates a new provider configuration.
 func NewProviderConfiguration(
-	veClient api.Client,
+	apiClient api.Client,
 	sshClient ssh.Client,
 ) ProviderConfiguration {
 	return ProviderConfiguration{
-		apiClient: veClient,
+		apiClient: apiClient,
 		sshClient: sshClient,
 	}
 }

proxmoxtf/resource/vm.go

@@ -1531,7 +1531,7 @@ func vmCreateClone(ctx context.Context, d *schema.ResourceData, m interface{}) d
 		}
 
 		// Only the root account is allowed to change the CPU architecture, which makes this check necessary.
-		if api.REST().IsRoot() ||
+		if api.API().IsRoot() ||
 			cpuArchitecture != dvResourceVirtualEnvironmentVMCPUArchitecture {
 			updateBody.CPUArchitecture = &cpuArchitecture
 		}
@@ -2050,7 +2050,7 @@ func vmCreateCustom(ctx context.Context, d *schema.ResourceData, m interface{})
 	}
 
 	// Only the root account is allowed to change the CPU architecture, which makes this check necessary.
-	if api.REST().IsRoot() ||
+	if api.API().IsRoot() ||
 		cpuArchitecture != dvResourceVirtualEnvironmentVMCPUArchitecture {
 		createBody.CPUArchitecture = &cpuArchitecture
 	}
@@ -2963,7 +2963,7 @@ func vmReadCustom(
 	} else {
 		// Default value of "arch" is "" according to the API documentation.
 		// However, assume the provider's default value as a workaround when the root account is not being used.
-		if !api.REST().IsRoot() {
+		if !api.API().IsRoot() {
 			cpu[mkResourceVirtualEnvironmentVMCPUArchitecture] = dvResourceVirtualEnvironmentVMCPUArchitecture
 		} else {
 			cpu[mkResourceVirtualEnvironmentVMCPUArchitecture] = ""
@@ -4158,7 +4158,7 @@ func vmUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.D
 		cpuUnits := cpuBlock[mkResourceVirtualEnvironmentVMCPUUnits].(int)
 
 		// Only the root account is allowed to change the CPU architecture, which makes this check necessary.
-		if api.REST().IsRoot() ||
+		if api.API().IsRoot() ||
 			cpuArchitecture != dvResourceVirtualEnvironmentVMCPUArchitecture {
 			updateBody.CPUArchitecture = &cpuArchitecture
 		}