fix(vm): ensure startup / shutdown delay is applied when order is not…

… configured (#479)
bpg · Aug 10, 2023 · 2cf64b8 · 2cf64b8
1 parent 8d0b3ed
commit 2cf64b8
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/proxmoxtf/resource/vm.go b/proxmoxtf/resource/vm.go
@@ -1303,18 +1303,16 @@ func VM() *schema.Resource {
 							Default:     dvResourceVirtualEnvironmentVMStartupOrder,
 						},
 						mkResourceVirtualEnvironmentVMStartupUpDelay: {
-							Type:             schema.TypeInt,
-							Description:      "A non-negative number defining the delay in seconds before the next VM is started",
-							Optional:         true,
-							Default:          dvResourceVirtualEnvironmentVMStartupUpDelay,
-							ValidateDiagFunc: validation.ToDiagFunc(validation.IntAtLeast(0)),
+							Type:        schema.TypeInt,
+							Description: "A non-negative number defining the delay in seconds before the next VM is started",
+							Optional:    true,
+							Default:     dvResourceVirtualEnvironmentVMStartupUpDelay,
 						},
 						mkResourceVirtualEnvironmentVMStartupDownDelay: {
-							Type:             schema.TypeInt,
-							Description:      "A non-negative number defining the delay in seconds before the next VM is shut down",
-							Optional:         true,
-							Default:          dvResourceVirtualEnvironmentVMStartupDownDelay,
-							ValidateDiagFunc: validation.ToDiagFunc(validation.IntAtLeast(0)),
+							Type:        schema.TypeInt,
+							Description: "A non-negative number defining the delay in seconds before the next VM is shut down",
+							Optional:    true,
+							Default:     dvResourceVirtualEnvironmentVMStartupDownDelay,
 						},
 					},
 				},
@@ -3206,8 +3204,9 @@ func vmGetStartupOrder(d *schema.ResourceData) *vms.CustomStartupOrder {
 
 		if startupOrder >= 0 {
 			order.Order = &startupOrder
-			return &order
 		}
+
+		return &order
 	}
 
 	return nil