chore: cleanup and fix linter errors (#290)

bpg · Apr 5, 2023 · 2fa9229 · 2fa9229
1 parent ed3dfea
commit 2fa9229
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 21 deletions.
diff --git a/.github/auto-label.yaml b/.github/auto-label.yaml
diff --git a/example/resource_virtual_environment_vm.tf b/example/resource_virtual_environment_vm.tf
@@ -101,11 +101,13 @@ resource "proxmox_virtual_environment_vm" "example" {
     ]
   }
 
-  initialization {
-    dns {
-      server = "8.8.8.8"
-    }
-  }
+# While overwriting the initialization block when cloning a template is possible, it is not recommended.
+# This will cause the coned VM to be reinitialized each time on re-apply.
+#  initialization {
+#    dns {
+#      server = "8.8.8.8"
+#    }
+#  }
 
 }
 

diff --git a/proxmoxtf/config.go b/proxmoxtf/config.go
@@ -4,12 +4,6 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
-/*
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at https://mozilla.org/MPL/2.0/.
- */
-
 package proxmoxtf
 
 import (

diff --git a/proxmoxtf/resource/firewall/rules.go b/proxmoxtf/resource/firewall/rules.go
@@ -389,6 +389,7 @@ func mapToBaseRule(rule map[string]interface{}) *firewall.BaseRule {
 
 	return baseRule
 }
+
 func mapToSecurityGroupBaseRule(rule map[string]interface{}) *firewall.BaseRule {
 	baseRule := &firewall.BaseRule{}
 
@@ -440,6 +441,7 @@ func baseRuleToMap(baseRule *firewall.BaseRule, rule map[string]interface{}) {
 		rule[mkRuleSPort] = *baseRule.SPort
 	}
 }
+
 func securityGroupBaseRuleToMap(baseRule *firewall.BaseRule, rule map[string]interface{}) {
 	if baseRule.Comment != nil {
 		rule[mkRuleComment] = *baseRule.Comment

diff --git a/proxmoxtf/resource/validator/firewall.go b/proxmoxtf/resource/validator/firewall.go
@@ -24,6 +24,7 @@ func FirewallRate() schema.SchemaValidateDiagFunc {
 		"Must be a valid rate expression, e.g. '1/second'",
 	))
 }
+
 func FirewallIFace() schema.SchemaValidateDiagFunc {
 	return validation.ToDiagFunc(validation.StringMatch(
 		ifaceExpression,