Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable terraform import #29

Closed
yuqo2450 opened this issue Oct 26, 2021 · 6 comments · Fixed by #390
Closed

Enable terraform import #29

yuqo2450 opened this issue Oct 26, 2021 · 6 comments · Fixed by #390
Labels
🙏 help wanted Extra attention is needed size/XXL ✨ enhancement New feature or request

Comments

@yuqo2450
Copy link

Hey there!
First of all nice work and thx for keeping this project alive!

I am using packer to create templates for my vms and it would be amazing, if it was possible, to import these templates into my terraform state. Therefore I wanted to ask if it was possible to add the terraform import functionality to this provider.
Another option could be to create a data resource for vms.

Thanks a lot!

@yuqo2450 yuqo2450 added the ✨ enhancement New feature or request label Oct 26, 2021
@bpg
Copy link
Owner

bpg commented Oct 27, 2021

Hey @Soras2919!

I appreciate your feedback! I took a quick pick at the spec: https://www.terraform.io/docs/extend/resources/import.html and it looks like the implementation would require quite a bit of work.

I'm using this provider for my hobby projects, and I have no particular interest in the import functionality, so that's unlikely I will have time to pull that by myself.

VM data source seems to be doable though, let me see into this.

Cheers,
@bpg

@github-actions
Copy link
Contributor

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@pescobar
Copy link
Contributor

are there any plans to add the import functionality?

@bpg
Copy link
Owner

bpg commented Jun 1, 2023

Hi @pescobar! 👋🏼
No, I don't have plans of adding this at the moment. But I'll reopen this ticket to collect more feedback from the community, and perhaps someone could contribute implementation of this feature.

In a meantime, would some minimalistic datasource(s) would be enough to unblock you, e.g. if you need to read just a few attributes of a PVE resource? There was a similar case before: #261

@bpg bpg reopened this Jun 1, 2023
@bpg bpg added 🙏 help wanted Extra attention is needed size/XXL and removed stale labels Jun 1, 2023
@pescobar
Copy link
Contributor

pescobar commented Jun 1, 2023

Thanks for the kind reply @bpg . No worries, no need to invest any time on adding extra datasources.

@ForsakenHarmony
Copy link
Contributor

ForsakenHarmony commented Jun 25, 2023

Was pretty simple, added a bunch of resources as a part of #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 help wanted Extra attention is needed size/XXL ✨ enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants