-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): efi disk, cpu numa #384
Conversation
Hey @ForsakenHarmony! 👋🏼 Would it be possible to extract the import support into a separate PR? I'll take a close look at the code and run some tests in my lab in the next few days. |
198e992
to
09ef57f
Compare
@bpg pulled out the import support |
Thanks! |
(cherry picked from commit 254724d)
31ccb36
to
bae73bd
Compare
@bpg feel free to fix anything broken |
also - add support for `pre-enrolled-keys` - add example - fix handling of `numa` flag when it's not in the template - cleanup linter errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few changes, most notable replacing size
with type
as per PVE docs only 2 sizes are supported (2m
and 4m
)
But awesome work anyway, I really appreciate the PR! 🚀
Description
Adds support for configuring the efi disk & numa for a VM
Contributor's Note
/docs
for any user-facing features or additions./examples
for any new or updated resources / data sources.make examples
to verify that the change works as expected.Community Note
Closes #316