Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): efi disk, cpu numa #384

Merged
merged 8 commits into from
Jul 1, 2023
Merged

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Jun 24, 2023

Description

Adds support for configuring the efi disk & numa for a VM

resource "proxmox_virtual_environment_vm" "vm" {
  cpu {
    numa: true
  }

  efi_disk {
    datastore_id = "local-zfs"
    size = "4M"
  }
}

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /examples for any new or updated resources / data sources.
  • I have ran make examples to verify that the change works as expected.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #316

@ForsakenHarmony ForsakenHarmony changed the title feat(vm): efi disk and import support feat(vm): efi disk, cpu numa and import support Jun 25, 2023
@bpg
Copy link
Owner

bpg commented Jun 25, 2023

Hey @ForsakenHarmony! 👋🏼
Thank you so much for contributing this!

Would it be possible to extract the import support into a separate PR?

I'll take a close look at the code and run some tests in my lab in the next few days.

@ForsakenHarmony
Copy link
Contributor Author

@bpg pulled out the import support

@ForsakenHarmony ForsakenHarmony changed the title feat(vm): efi disk, cpu numa and import support feat(vm): efi disk, cpu numa Jun 25, 2023
@bpg
Copy link
Owner

bpg commented Jun 29, 2023

@bpg pulled out the import support

Thanks!
I'm still testing this functionality. Hope you don't mind if I make a few adjustments to your PR :)

@ForsakenHarmony
Copy link
Contributor Author

@bpg feel free to fix anything broken

also
- add support for `pre-enrolled-keys`
- add example
- fix handling of `numa` flag when it's not in the template
- cleanup linter errors
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 1, 2023
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few changes, most notable replacing size with type as per PVE docs only 2 sizes are supported (2m and 4m)

But awesome work anyway, I really appreciate the PR! 🚀

@bpg bpg merged commit e9a74e9 into bpg:main Jul 1, 2023
@ghost ghost mentioned this pull request Jul 1, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/efi-disks branch July 3, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EFI disk support
2 participants