-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vm): Add parser for CustomEFIDisk #208
Conversation
also update doc to match description from the official PVE documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @kaje783! 👍🏻
Just a minor feedback about the size parsing.
size := strings.ReplaceAll(v[1], "M", "") | ||
iv, err := strconv.Atoi(size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use parseDiskSize(string)
from utils.go
, for consistency.
size := strings.ReplaceAll(v[1], "M", "") | |
iv, err := strconv.Atoi(size) | |
iv, err := parseDiskSize(v[1]) |
@bpg the function |
readd the remove space by github space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've added unit tests for the func and refactored the code a bit to address linter errors and remove duplication.
LGTM! 🚀
Community Note
Add parser to use efi disk for UEFI
Closes #202