Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm,lxc): Improved support for different disk size units #326

Merged
merged 5 commits into from
May 10, 2023
Merged

feat(vm,lxc): Improved support for different disk size units #326

merged 5 commits into from
May 10, 2023

Commits on May 7, 2023

  1. Convert to Regex for size conversion

    @zeddD1abl0
    zeddD1abl0 committed May 7, 2023
    Configuration menu
    Copy the full SHA
    970e3c1 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge branch 'main' into 86-take-2-add-sizing-regex

    @bpg
    bpg authored May 9, 2023
    Configuration menu
    Copy the full SHA
    b841e0e View commit details
    Browse the repository at this point in the history

  2. add unit tests 

    make the size unit mandatory as it was before
remove support for floating point strings
remove support for optional space(s) between size number and units
    @bpg
    bpg committed May 9, 2023
    Configuration menu
    Copy the full SHA
    777b737 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. refactoring to DiskSize datatype 

    - move the code under types/disk_size.go
- add unit tests
- add "to string" conversion
- refactor all API types to use `DiskSize` type instead of string/int, and use JSON marshalling / unmarshalling where possible
    @bpg
    bpg committed May 10, 2023
    Configuration menu
    Copy the full SHA
    c810feb View commit details
    Browse the repository at this point in the history

  2. add comments to exported methods

    @bpg
    bpg committed May 10, 2023
    Configuration menu
    Copy the full SHA
    390c6d7 View commit details
    Browse the repository at this point in the history