fix(vm): Regression: wait for 'net.IsGlobalUnicast' IP address (#100) #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VM can get IPv6 link-local address faster than a DHCP server response, that results in 'ipv4_addresses' output being an empty list. It is then impossible to provision the VM using 'connection.host' field derived from 'self.ipv4_addresses'. Once again change waiting for IP address to wait for better address than IPv4 link-local addresses and IPv6 link-local addresses. Should not break bpg#182, because it requires only one GlobalUnicast address per VM.
bpg
approved these changes
May 23, 2023
There was a problem hiding this comment.
Hi @otopetrik 👋🏼 Thanks for testing and for the fix!
LGTM! 🚀
bpg
changed the title
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM can get IPv6 link-local address faster than a DHCP server response, that results in 'ipv4_addresses' output being an empty list. It is then impossible to provision the VM using 'connection.host' field derived from 'self.ipv4_addresses'.
Once again change waiting for IP address to wait for better address than IPv4 link-local addresses and IPv6 link-local addresses.
Should not break #182, because it requires only one GlobalUnicast address per VM.
Contributor's Note
Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.
/docsfor any user-facing features or additions./examplesfor any new or updated resources / data sources.make examplesto verify that the change works as expected.Community Note
Relates OR Closes #100