Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): Don't add an extra efi_disk entry #435

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(vm): Don't add an extra efi_disk entry #435

merged 3 commits into from
Jul 20, 2023

Conversation

qazbnm456
Copy link
Contributor

When I tried to clone from a template with the default bios setting (seabios), there should be no efi_disk in the config. However, the post body would contain an extra efi_disk due to these lines (from DefaultFunc).

image

I believed this issue was like #223.


Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

@bpg
Copy link
Owner

bpg commented Jul 19, 2023

Hey @qazbnm456 👋🏼 Thanks for the PR!
I think those defaults are needed for other use cases though. I don't remember details at the moment, but will run some tests later this week and get back to you.

Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the issue I was thinking about was related to adding new fields to a resource without adding corresponding keys to the defaults map. Removing defaults map entirely seems fine in this case, so LGTM!

Thanks for the PR @qazbnm456!

@bpg bpg enabled auto-merge (squash) July 20, 2023 22:59
@bpg bpg merged commit 6781c03 into bpg:main Jul 20, 2023
@ghost ghost mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants