Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): add support for SMBIOS settings #454

Merged
merged 8 commits into from
Aug 6, 2023
Merged

feat(vm): add support for SMBIOS settings #454

merged 8 commits into from
Aug 6, 2023

Conversation

bpg
Copy link
Owner

@bpg bpg commented Aug 4, 2023

  smbios {
    family       = "family"
    manufacturer = "manufacturer"
    product      = "product"
    serial       = "serial"
    sku          = "sku"
    version      = "version"
  }
Screenshot 2023-08-03 at 9 04 48 PM

Contributor's Note

Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /examples for any new or updated resources / data sources.
  • I have ran make examples to verify that the change works as expected.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #451
Closes #353

@bpg bpg added the autoapprove label Aug 4, 2023
mergify[bot]
mergify bot previously approved these changes Aug 4, 2023
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg
Copy link
Owner Author

bpg commented Aug 4, 2023

@all-contributors please add @si458 for bug,test

@allcontributors
Copy link
Contributor

@bpg

I've put up a pull request to add @si458! 🎉

mergify[bot]
mergify bot previously approved these changes Aug 5, 2023
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg enabled auto-merge (squash) August 6, 2023 00:29
@bpg bpg merged commit 85ff60d into main Aug 6, 2023
10 of 11 checks passed
@bpg bpg deleted the vm-add-smbios branch August 6, 2023 00:31
@ghost ghost mentioned this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow setting smbios for each VM (optional values) Expose SMBIOS options
1 participant