virtual_environment_datastores.go: Update remote command to get datasource path

[mattburchett]

During the setup of this Terraform module, I was trying to create a cloud-init template based on this example. I noticed that when trying to retrieve the datasource path for NFS mounts, it was failing with the following error:

proxmox_virtual_environment_file.ubuntu_cloud_config["lrhq-ubuntu-test01"]: Creating...
proxmox_virtual_environment_file.test: Creating...
╷
│ Error: Failed to determine the datastore path
│ 
│   with proxmox_virtual_environment_file.ubuntu_cloud_config["lrhq-ubuntu-test01"],
│   on files.tf line 1, in resource "proxmox_virtual_environment_file" "ubuntu_cloud_config":
│    1: resource "proxmox_virtual_environment_file" "ubuntu_cloud_config" {
│ 
╵
╷
│ Error: Failed to determine the datastore path
│ 
│   with proxmox_virtual_environment_file.test,
│   on files2.tf line 1, in resource "proxmox_virtual_environment_file" "test":
│    1: resource "proxmox_virtual_environment_file" "test" { 
│ 
╵

When running the original shell command in the code from my Proxmox host, it returns nothing:

# grep -Pzo ': storage-arn\s+path\s+[^\s]+' /etc/pve/storage.cfg | grep -Pzo '/[^\s]*' | tr -d '\000'
#

However, testing it with the 'local' datasource, it works as expected.

# grep -Pzo ': local\s+path\s+[^\s]+' /etc/pve/storage.cfg | grep -Pzo '/[^\s]*' | tr -d '\000'
/var/lib/vz
#

That's when we noticed that the regex was assuming that "path" would be available on the next line. We rewrote the command to be agnostic of which line "path" exists on.

Credit to @AndrewPaglusch for helping solve this issue with me.

[bpg]

Thanks @mattburchett & @AndrewPaglusch for the fix! Could you please attach an example of a /etc/pve/storage.cfg section that the new code should parse?

[mattburchett]

Hey @bpg, sorry for the delay. I'm attaching a file containing my /etc/pve/storage.cfg for testing.

storage.cfg.txt

[bpg]

The original code doesn't have much of unit testing around that area, and adding them is not a trivial task :(
I've manually test the new code with the provided example and few other examples from my own environment, and everything seems to be working as expected.

Thanks @mattburchett !