Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lxc): multi-line description always shows as changed #611

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(lxc): multi-line description always shows as changed #611

merged 1 commit into from
Oct 9, 2023

Conversation

bpg
Copy link
Owner

@bpg bpg commented Oct 9, 2023

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Before:
Screenshot 2023-10-08 at 9 09 38 PM

After:
Screenshot 2023-10-08 at 9 09 47 PM

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #601

@bpg
fix(lxc): multi-line description always shows as changed
b9d5a91 
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
@bpg bpg marked this pull request as ready for review October 9, 2023 01:11
@bpg bpg added the autoapprove label Oct 9, 2023
mergify[bot]
mergify bot approved these changes Oct 9, 2023
View reviewed changes
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 088ad09 into main Oct 9, 2023
8 checks passed
@bpg bpg deleted the fix-container-multiline-description branch October 9, 2023 01:14
@ghost ghost mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
autoapprove size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LXC description field is always marked as changed
1 participant
@bpg