-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): Add Win 11 as os type #720
Conversation
Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dark-vex!
Thanks a lot for the PR!
I noticed the formatting is a bit off there (I guess there are spaces instead of tabs). Could you please run make fmt
or make lint
on your branch to fix that?
Thanks!
Yes absolutely, I've used spaces from |
Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@all-contributors please add @dark-vex for code |
I've put up a pull request to add @dark-vex! 🎉 |
Contributor's Note
/docs
for any user-facing features or additions./example
for any new or updated resources / data sources.make example
to verify that the change works as expected.Proof of Work
Community Note
Closes #719