Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): Add Win 11 as os type #720

Merged
merged 3 commits into from
Nov 16, 2023
Merged

feat(vm): Add Win 11 as os type #720

merged 3 commits into from
Nov 16, 2023

Conversation

dark-vex
Copy link
Contributor

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #719

Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dark-vex!

Thanks a lot for the PR!

I noticed the formatting is a bit off there (I guess there are spaces instead of tabs). Could you please run make fmt or make lint on your branch to fix that?

Thanks!

@dark-vex
Copy link
Contributor Author

Hi @dark-vex!

Thanks a lot for the PR!

I noticed the formatting is a bit off there (I guess there are spaces instead of tabs). Could you please run make fmt or make lint on your branch to fix that?

Thanks!

Yes absolutely, I've used spaces from vi editor, let me fix it, apologies!

Signed-off-by: Daniele De Lorenzi <daniele.delorenzi@fastnetserv.net>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bpg bpg enabled auto-merge (squash) November 16, 2023 13:55
@bpg bpg merged commit 0eeb7a7 into bpg:main Nov 16, 2023
8 checks passed
@ghost ghost mentioned this pull request Nov 16, 2023
@bpg
Copy link
Owner

bpg commented Nov 17, 2023

@all-contributors please add @dark-vex for code

Copy link
Contributor

@bpg

I've put up a pull request to add @dark-vex! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win11 os type
2 participants