Fix disk import when VM template has multiple disks #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disk import operation is not exposed via Proxmox APIs, so implemented as a sequence of commands run as an inline script via ssh. `qm importdisk` is used to import a disk into VM from an external file, however, it auto-generates the disk ID. The following command `qm set` is used to assign the imported disk to a VM, and it requires the disk ID as a parameter. Update the import logic to read the disk ID from the output of `qm importdisk` command rather than trying to assume it from a number of disks defined in the VM.
bpg
force-pushed
the
vm-multiple-disks-fix
branch
from
2b17cef
to
367061e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk import operation is not exposed via Proxmox APIs, so implemented as a sequence of commands run as an inline script via ssh.
qm importdiskis used to import a disk into VM from an external file, however, it auto-generates the disk ID.The following command
qm setis used to assign the imported disk to a VM, and it requires the disk ID as a parameter.Update the import logic to read the disk ID from the output of
qm importdiskcommand rather than trying to assume it from a number of disks defined in the VM.Community Note
Closes #88