Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .python-version file for ST4 #2

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

themilkman
Copy link

This will let ST >=4 builds use the 3.8 plugin host instead of the old 3.3.
I've had this running for quite a long time and it did work as expected.

Cheers & thanks for your helpful plugin!

@themilkman
Copy link
Author

Any chance to get this merged and released, @bpicolo ? :-)

@bpicolo
Copy link
Owner

bpicolo commented Mar 24, 2023

@themilkman Absolutely! Thank you. Glad to see some folk still find this useful.

Released...might be a harder question, will see what I can do. I don't have any recollection on how to do that haha

@bpicolo bpicolo merged commit aaba919 into bpicolo:master Mar 24, 2023
@bpicolo
Copy link
Owner

bpicolo commented Mar 24, 2023

Well, I tagged a release on github. Reading through https://packagecontrol.io/docs/submitting_a_package, I think that's all I need?

As far as I can tell, the metadata is still configured, and nothing jumps out as being incorrect in the modern era:
https://github.com/wbond/package_control_channel/blob/master/repository/c.json#L3766

The version is still 2014 on https://packagecontrol.io/packages/Copy%20Relative%20Path though. My current guess is it takes time for the package manager to pick up new versions. Can you confirm or deny that @themilkman ?

edit: actually, it looks like this package still uses deprecated branch-based versioning... I can probably go update that in the other repo

@bpicolo
Copy link
Owner

bpicolo commented Mar 24, 2023

Created a PR in that repo to switch to tag-based versioning: wbond/package_control_channel#8714

@themilkman
Copy link
Author

Thank you so much @bpicolo !

Unfortunately I do not maintain any package on my own and do not know how the release process works... 🙈 hopefully your way succeeds. What I do know is that it sometimes takes a little bit of time until the new version appears on the pc website (I guess there is a periodic crawler).

I'll stay tuned. Again thank you very much!

@themilkman
Copy link
Author

It arrived, thanks again for your work! 🙏 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants