Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Append TextAnnotation" title doesn't translate fully #22

Closed
corocoto opened this issue Jul 12, 2023 · 4 comments
Closed

"Append TextAnnotation" title doesn't translate fully #22

corocoto opened this issue Jul 12, 2023 · 4 comments
Labels
enhancement New feature or request pr welcome We rely on a community contribution to improve this.

Comments

@corocoto
Copy link
Contributor

Describe the Bug

I try to translate "Append TextAnnotation" to russian locale via additionalModules property:

additionalModules: [
  {
     translate: ['value', customTranslate(ruLocale)],
   },
],

The problem is that the word TextAnnotation doesn't translate, even if I put these properties into my locale file. It's that I mean:

// ru.js
export default {
...
 'Append TextAnnotation': 'Добавить комментарий',
'Text Annotation': 'Комментарий',
'TextAnnotation': 'Комментарий',
}

Steps to Reproduce

  1. Use additionalModules property with translate block:
additionalModules: [
  {
     translate: ['value', customTranslate([LOCALE FILE])],
   },
],
  1. Add translations for "Append TextAnnotation", "Text Annotation" and "TextAnnotation" text blocks into your locale file
  2. Check result:

image

Expected Behavior

"Append TextAnnotation" should translated fully, but not only "Append" word.

Environment

  • Host (Browser/Node version), if applicable: Chrome 114.0.5735.198
  • OS: macOS Ventura v.13.4.1
  • Library version: Latest
@corocoto corocoto added the bug Something isn't working label Jul 12, 2023
@philippfromme
Copy link
Contributor

Currently, element types are not translated (cf. https://github.com/bpmn-io/bpmn-js/blob/develop/lib/features/context-pad/ContextPadProvider.js#L238). You'd have to override the provider or the translate service to change this behavior.

@nikku
Copy link
Member

nikku commented Jul 20, 2023

@corocoto Happy to take a contribution to translate the element types.

@nikku nikku added backlog Queued in backlog enhancement New feature or request pr welcome We rely on a community contribution to improve this. and removed bug Something isn't working labels Jul 20, 2023
@corocoto
Copy link
Contributor Author

corocoto commented Jul 20, 2023

@nikku, yeah, sure. I'll try to do this

@corocoto
Copy link
Contributor Author

@nikku, @philippfromme, done. You can review these PR's.

philippfromme added a commit that referenced this issue Jul 31, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome We rely on a community contribution to improve this.
Development

No branches or pull requests

3 participants