Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v5.6.0 #991

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Prepare v5.6.0 #991

merged 3 commits into from
Oct 19, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Oct 18, 2023

Let's cut this release to integrate the changes downstream!

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 18, 2023
@smbea
Copy link
Contributor

smbea commented Oct 19, 2023

Let's just resolve conflicts and we can go ahead

@nikku
Copy link
Member Author

nikku commented Oct 19, 2023

Doing it!

@nikku nikku requested review from smbea and barmac October 19, 2023 08:21
@nikku
Copy link
Member Author

nikku commented Oct 19, 2023

Updated.

@barmac
Copy link
Member

barmac commented Oct 19, 2023

Shall we hold this till bpmn-io/bpmn-js-element-templates#25 (comment)?

@barmac
Copy link
Member

barmac commented Oct 19, 2023

🔴 If we update camunda-bpmn-js-behaviors, the zeebe:subscription will be broken due to the same reason as in bpmn-js-element-templates. We should add the property in one go instead of multi-command shenanigans: https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/src/provider/zeebe/properties/MessageProps.js#L138

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's integrate behaviors correctly (I will do that).

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 19, 2023
@barmac
Copy link
Member

barmac commented Oct 19, 2023

Done via a06e55c

This shows how multicommand command breaks the command atomicity :/

@barmac barmac merged commit bb56a9f into main Oct 19, 2023
7 checks passed
@barmac barmac deleted the prepare-v5-6-0 branch October 19, 2023 12:17
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants