Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected Layout After Using Space Tool #1019

Closed
philippfromme opened this issue May 8, 2019 · 6 comments
Closed

Unexpected Layout After Using Space Tool #1019

philippfromme opened this issue May 8, 2019 · 6 comments
Assignees
@philippfromme
Labels
bug Something isn't working channel:support
Milestone
M34

Comments

@philippfromme
Copy link
Contributor

philippfromme commented May 8, 2019 •
edited by nikku
Loading

Reproduce

  1. Create a bpmn:SubProcess with an appended flow node
  2. Use the space tool to create space to the right

Expected Behavior:

The connection bewteen the two doesn't change.

Actual Behavior:

The connection between the two is laid out in an unexpected way.

foobar

Related to SUPPORT-5824
@philippfromme philippfromme added the bug Something isn't working label May 8, 2019
@pinussilvestrus pinussilvestrus mentioned this issue May 9, 2019
Closed
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label May 9, 2019
@gustavjf gustavjf mentioned this issue May 13, 2019
Merged
@gustavjf gustavjf mentioned this issue May 28, 2019
Closed
@philippfromme
Copy link
Contributor Author

Due to the sequence of first resizing and then moving shapes when using the space tool the layout ends up broken.

To prevent that from happening we should differenciate between adding space and removing space and split up moving shapes:

Adding Space

  1. move outer shapes
  2. resize
  3. move inner shapes

Removing Space

  1. move inner shapes
  2. resize
  3. move outer shapes

@nikku
Copy link
Member

nikku commented Jun 12, 2019

Could you link the support case?

@nikku nikku added the PM label Jun 12, 2019
@kurtudis
Copy link

Could you link the support case?

SUPPORT-5824

@nikku
Copy link
Member

nikku commented Jun 12, 2019

Thanks!

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 13, 2019
@philippfromme
fix(space-tool): move and resize shapes in correct order
54b2cef 
Related to bpmn-io/bpmn-js#1019
@philippfromme philippfromme mentioned this issue Jun 13, 2019
Merged
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 13, 2019
@philippfromme
fix(space-tool): move and resize shapes in correct order
889752c 
Related to bpmn-io/bpmn-js#1019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 13, 2019
@philippfromme
fix(space-tool): move and resize shapes in correct order
1663305 
Related to bpmn-io/bpmn-js#1019
@philippfromme philippfromme mentioned this issue Jun 14, 2019
Closed
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 14, 2019
@philippfromme
fix(space-tool): move and resize shapes in correct order
f06d68a 
Related to bpmn-io/bpmn-js#1019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 14, 2019
@philippfromme
fix(space-tool): move and resize shapes in correct order
045e55a 
Related to bpmn-io/bpmn-js#1019
@philippfromme
Copy link
Contributor Author

@nikku Let's have a look at this together next week. 🍻

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 10, 2020
@philippfromme
fix(space-tool): move and resize shapes in correct order
3fd6a77 
Related to bpmn-io/bpmn-js#1019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 13, 2020
@philippfromme
fix(space-tool): move and resize shapes in correct order
b29ad71 
Related to bpmn-io/bpmn-js#1019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 13, 2020
@philippfromme
fix(space-tool): move and resize shapes in correct order
d49d931 
Related to bpmn-io/bpmn-js#1019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 13, 2020
@philippfromme
fix(space-tool): move and resize shapes in correct order
81b981b 
Related to bpmn-io/bpmn-js#1019
Related to bpmn-io7bpmn-js#878
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Jan 19, 2020
@nikku nikku added ready Ready to be worked on and removed in progress Currently worked on labels Jan 24, 2020 — with bpmn-io-tasks
@nikku nikku added this to the M34 milestone Feb 6, 2020
@nikku
Copy link
Member

nikku commented Feb 6, 2020

Closed via #1269

@nikku nikku closed this as completed Feb 6, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Feb 6, 2020
nikku added a commit that referenced this issue Feb 7, 2020
@nikku
chore(project): bump to diagram-js@6.4.0
5844ede 
Closes #1270
Closes #1019
Closes #878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working channel:support
Projects
None yet
Milestone
M34
Development

No branches or pull requests
4 participants
@nikku @philippfromme @pinussilvestrus @kurtudis