Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken connection layout when reconnecting to create a loop #1121

Closed
barmac opened this issue Jul 3, 2019 · 1 comment
Closed

Broken connection layout when reconnecting to create a loop #1121

barmac opened this issue Jul 3, 2019 · 1 comment
Assignees
@philippfromme
Labels
bug Something isn't working modeling
Milestone
M31

Comments

@barmac
Copy link
Member

barmac commented Jul 3, 2019

Describe the Bug

This applies only to connections with more than 2 waypoints. When reconnecting start/end to form a loop, the connection is laid out incorrectly. It applies to both old and current bpmn-js versions, although the way the connection is laid out is different.

bpmn-js@<=3

layout-1

bpmn-js@4.0.0-beta.11

layout-2

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create two flow nodes connected with a complex connection
  2. Reconnect start/end to form a loop

Expected Behavior

Layout as if the loop were created from scratch.

Environment

Please complete the following information:

  • Browser: Camunda Modeler
  • OS: MacOS
  • Library version: applies to bpmn-js used in Camunda Modeler 2.2.4, 3.1.1 and bpmn-js@4.0.0-beta.11
@barmac barmac added bug Something isn't working modeling labels Jul 3, 2019
@barmac barmac mentioned this issue Jul 3, 2019
Closed
21 tasks
@nikku nikku added the backlog Queued in backlog label Jul 8, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M30 milestone Jul 8, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 8, 2019
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Aug 6, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus self-assigned this Aug 6, 2019
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed in progress Currently worked on labels Aug 7, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus removed their assignment Aug 7, 2019
@nikku nikku modified the milestones: M30, M31 Aug 12, 2019
philippfromme added a commit that referenced this issue Aug 19, 2019
@philippfromme
fix(bpmn-layouter): get preferred layout from orientation
89aa2ab 
Requires bpmn-io/diagram-js#401

Closes #1121
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Aug 19, 2019
@philippfromme philippfromme mentioned this issue Aug 19, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 19, 2019
@philippfromme philippfromme mentioned this issue Aug 19, 2019
Merged
@philippfromme philippfromme added in progress Currently worked on and removed needs review Review pending labels Aug 20, 2019 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 20, 2019
philippfromme added a commit that referenced this issue Aug 20, 2019
@philippfromme
fix(bpmn-layouter): get preferred layout from orientation
48c831d 
Requires bpmn-io/diagram-js#401

Closes #1121
philippfromme added a commit that referenced this issue Aug 20, 2019
@philippfromme
fix(bpmn-layouter): get preferred layout from orientation
e6cbd62 
Requires bpmn-io/diagram-js#401

Closes #1121
merge-me bot pushed a commit that referenced this issue Aug 21, 2019
@philippfromme @merge-me
fix(bpmn-layouter): get preferred layout from orientation
6aaf816 
Requires bpmn-io/diagram-js#401

Closes #1121
@pinussilvestrus
Copy link
Contributor

Closed via 6aaf816

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working modeling
Projects
None yet
Milestone
M31
Development

No branches or pull requests
4 participants
@nikku @philippfromme @pinussilvestrus @barmac