Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element Behind Parent #1129

Closed
philippfromme opened this issue Jul 16, 2019 · 3 comments · Fixed by bpmn-io/diagram-js#385
Closed

Element Behind Parent #1129

philippfromme opened this issue Jul 16, 2019 · 3 comments · Fixed by bpmn-io/diagram-js#385
Assignees
@philippfromme
Labels
bug Something isn't working
Milestone
M29

Comments

@philippfromme
Copy link
Contributor

Unfortunately the fix I provided in bpmn-io/diagram-js#381 results in a bug.

fail

Instead of not updating when there are less than two children the prepending should be executed in a save way.
@philippfromme philippfromme added bug Something isn't working ready Ready to be worked on labels Jul 16, 2019
@philippfromme philippfromme added this to the M30 milestone Jul 16, 2019
@philippfromme philippfromme self-assigned this Jul 16, 2019
@nikku
Copy link
Member

nikku commented Jul 16, 2019

Good catch. Do you look into this issue?

@nikku nikku mentioned this issue Jul 16, 2019
Closed
21 tasks
@philippfromme
Copy link
Contributor Author

I fucked up, I'll fix it. 👍

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 16, 2019
@philippfromme
fix(graphics-factory): replace instead of prepend if same node
9fb76f3 
* prevents IE from blowing up

Closes bpmn-io/bpmn-js#1129
@philippfromme philippfromme mentioned this issue Jul 16, 2019
Merged
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 17, 2019
@philippfromme
fix(graphics-factory): do not prepend to self
2b6ed0f 
* prevents IE from blowing up

Closes bpmn-io/bpmn-js#1129
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 17, 2019
@philippfromme
fix(graphics-factory): do not prepend to self
08da15a 
* prevents IE from blowing up

Closes bpmn-io/bpmn-js#1129
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Jul 17, 2019 — with bpmn-io-tasks
philippfromme added a commit that referenced this issue Jul 17, 2019
@philippfromme
fix(graphics-factory): add test case verifying fix
cd83a82 
Related to #1129
@philippfromme philippfromme mentioned this issue Jul 17, 2019
Merged
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Jul 17, 2019 — with bpmn-io-tasks
philippfromme added a commit that referenced this issue Jul 17, 2019
@philippfromme
fix(graphics-factory): add test case verifying fix
7260d33 
Related to #1129
merge-me bot pushed a commit that referenced this issue Jul 17, 2019
@philippfromme @merge-me
fix(graphics-factory): add test case verifying fix
dda3073 
Related to #1129
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 18, 2019
@philippfromme
fix(graphics-factory): do not prepend to self
3c70235 
Related to bpmn-io/bpmn-js#1129
merge-me bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jul 18, 2019
@philippfromme @merge-me
fix(graphics-factory): do not prepend to self
bab7b80 
Related to bpmn-io/bpmn-js#1129
@nikku nikku closed this as completed Jul 18, 2019
@nikku nikku removed the needs review Review pending label Jul 18, 2019 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented Jul 18, 2019

Closed via bpmn-io/diagram-js#385.

nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jul 18, 2019
@philippfromme @nikku
fix(graphics-factory): do not prepend to self
df23b3b 
Related to bpmn-io/bpmn-js#1129
nikku pushed a commit that referenced this issue Jul 18, 2019
@philippfromme @nikku
fix(graphics-factory): add test case verifying fix
d0044f8 
Related to #1129
@nikku nikku modified the milestones: M30, M29 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

fix(graphics-factory): do not prepend to self bpmn-io/diagram-js
2 participants
@nikku @philippfromme