Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When remove child lane in diagram, other related lane and diagram deformed #1253

Closed
Varooneh opened this issue Dec 3, 2019 · 9 comments
Closed

When remove child lane in diagram, other related lane and diagram deformed #1253

Varooneh opened this issue Dec 3, 2019 · 9 comments
Assignees
@nikku
Labels
bug Something isn't working
Milestone
M33

Comments

@Varooneh
Copy link

Varooneh commented Dec 3, 2019 •
edited by nikku
Loading

Describe the Bug
If you create bpmn model in new version at bpmn online demo and need to create multiple child lanes in a parent lane, when remove any child from parent, diagram deformed and sometimes you can not continue edit diagram.

Steps to Reproduce

  1. I created a diagram in demo.bpmn.io like this :
    before_remove

  2. And need to remove a child lane, when remove child, diagram deformed, like this:
    after_remove

Environment

  • Browser: [e.g. Chrome (latest version)]
  • OS: [Windows 10]
  • Library version: v5.x, v6.x

Works in v3.0.1 and v4.0.1.
@Varooneh Varooneh added the bug Something isn't working label Dec 3, 2019
@nikku
Copy link
Member

nikku commented Dec 3, 2019

What is the last version of bpmn-js that worked here?

@Varooneh
Copy link
Author

Varooneh commented Dec 3, 2019 •
edited
Loading

What is the last version of bpmn-js that worked here?

I used verion 3.0.4 and I've not any problem. I tested on online demo and see this problem.

@nikku
Copy link
Member

nikku commented Dec 3, 2019

Yes

I expected something linke "v3.5.0 is the last version that properly handles lanes".

@Varooneh
Copy link
Author

Varooneh commented Dec 3, 2019

@nikku
I used bpmn version 3.0.4, in this version I've not any problem, also I draw diagram in demo.bpmn.io and see this problem.

@pinussilvestrus
Copy link
Contributor

The last version which worked is v4.0.4, beginning with v5.x the bug occurs.

@nikku
Copy link
Member

nikku commented Dec 9, 2019

Thanks for verifying this @pinussilvestrus.

@nikku
Copy link
Member

nikku commented Dec 9, 2019

I've updated the issue description accordingly.

@nikku nikku self-assigned this Dec 9, 2019
@nikku nikku added the ready Ready to be worked on label Dec 9, 2019 — with bpmn-io-tasks
nikku added a commit that referenced this issue Dec 11, 2019
@nikku
fix(modeling): correct creation of nested lanes
cccdd64 
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels Dec 11, 2019 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented Dec 11, 2019

This is tightly related to #1254, let me elaborate:

Due to a bug introduced with bpmn-js@5 nested lanes are not properly serialized to the BPMN 2.0 anymore. In fact, they are always serialized as a direct child of the participant/pool root.

As a result, our layout algorithm fails.

@nikku nikku mentioned this issue Dec 11, 2019
Merged
fake-join bot pushed a commit that referenced this issue Dec 11, 2019
@nikku @fake-join
fix(modeling): correct creation of nested lanes
b4b5d1d 
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
@nikku
Copy link
Member

nikku commented Dec 11, 2019

Closed via #1256.

@nikku nikku closed this as completed Dec 11, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 11, 2019
@nikku nikku added this to the M33 milestone Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Projects
None yet
Milestone
M33
Development

No branches or pull requests
3 participants
@nikku @pinussilvestrus @Varooneh