Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels change color when connection preview is active #1380

Closed
barmac opened this issue Dec 1, 2020 · 0 comments · Fixed by #1415
Closed

Labels change color when connection preview is active #1380

barmac opened this issue Dec 1, 2020 · 0 comments · Fixed by #1415
Assignees
@pinussilvestrus
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented Dec 1, 2020

Describe the Bug

Have a look at the screencast:

noop

Steps to Reproduce

  1. Start connecting
  2. now this happens

Expected Behavior

No change in styles.

Environment

  • Host (Browser/Node version), if applicable: Chrome 87, Firefox Developer Edition 84
  • OS: MacOS 10.15.7
  • Library version: v7.4.1
@barmac barmac added bug Something isn't working backlog Queued in backlog good first issue Good for newcomers labels Dec 1, 2020
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Jan 20, 2021
@pinussilvestrus pinussilvestrus self-assigned this Jan 20, 2021
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed backlog Queued in backlog labels Jan 20, 2021
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 20, 2021
fix: properly set attach-allowed-stroke-color
3c55991 
Related to bpmn-io/bpmn-js#1380
@pinussilvestrus pinussilvestrus mentioned this issue Jan 20, 2021
Merged
9 tasks
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Jan 20, 2021 — with bpmn-io-tasks
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 21, 2021
@fake-join
fix: properly set attach-allowed-stroke-color
f9ffb44 
Related to bpmn-io/bpmn-js#1380
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Jan 21, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 22, 2021
@nikku
fix: properly set attach-allowed-stroke-color
d4ff7d0 
Related to bpmn-io/bpmn-js#1380
nikku added a commit that referenced this issue Jan 28, 2021
@nikku
deps: bump to diagram-js@7.2.0
e58d334 
Closes #1380
@nikku nikku mentioned this issue Jan 28, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jan 28, 2021
@fake-join fake-join bot closed this as completed in #1415 Jan 28, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 28, 2021
fake-join bot pushed a commit that referenced this issue Jan 28, 2021
@nikku @fake-join
deps: bump to diagram-js@7.2.0
12495b7 
Closes #1380
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to diagram-js@7.2.0 bpmn-io/bpmn-js
3 participants
@nikku @pinussilvestrus @barmac