Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partipant New Parent Indication Stays after Adding Boundary Event #1413

Closed
philippfromme opened this issue Jan 25, 2021 · 1 comment · Fixed by #1414
Closed

Partipant New Parent Indication Stays after Adding Boundary Event #1413

philippfromme opened this issue Jan 25, 2021 · 1 comment · Fixed by #1414
Labels
bug Something isn't working

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

If a participant has lanes the new-parent marker is not removed from it when adding a boundary event to a child.

participant-background

Steps to Reproduce

  1. Create a participant with lanes
  2. Add a task
  3. Add a boundary event to the task

Expected Behavior

The new-parent should be reset.

Environment

  • Library version: v8.0.1
@philippfromme philippfromme added the bug Something isn't working label Jan 25, 2021
@MaxTru MaxTru added the backlog Queued in backlog label Jan 26, 2021 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented Jan 26, 2021

That bug is in the code base since November 2019.

nikku added a commit that referenced this issue Jan 26, 2021
@nikku
fix(modeling): if we fix hover, we gotta fix out, too
77faa79 
This ensures our FixHoverBehavior (that ensures we drop onto /
connect to participants, not lanes) does fix the hover element
during *.out, too.

Otherwise there is no way for other behaviors to correctly
remove hover indicators.

Closes #1413
@nikku nikku mentioned this issue Jan 26, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Jan 26, 2021
@fake-join fake-join bot closed this as completed in #1414 Jan 28, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 28, 2021
fake-join bot pushed a commit that referenced this issue Jan 28, 2021
@nikku @fake-join
fix(modeling): if we fix hover, we gotta fix out, too
6f12136 
This ensures our FixHoverBehavior (that ensures we drop onto /
connect to participants, not lanes) does fix the hover element
during *.out, too.

Otherwise there is no way for other behaviors to correctly
remove hover indicators.

Closes #1413
philippfromme pushed a commit that referenced this issue Jan 28, 2021
@nikku @philippfromme
fix(modeling): if we fix hover, we gotta fix out, too
6c02ecd 
This ensures our FixHoverBehavior (that ensures we drop onto /
connect to participants, not lanes) does fix the hover element
during *.out, too.

Otherwise there is no way for other behaviors to correctly
remove hover indicators.

Closes #1413
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modeling): if we fix hover, we gotta fix out, too bpmn-io/bpmn-js
3 participants
@nikku @philippfromme @MaxTru