Empty line at the end of description didn't vanish after deletion

[ingorichtsmeier]

I add a newline at the end of a task name.

Then I delete the the empty line.

Expected Behavior

The task name is in the middle of the task

Actual Behavior

The task name is shift to the top

Steps to reproduce the Behavior

1. Add a newline with shift+enter at the end of a task name.
2. Click to the next task.
3. Delete the empty line

[nikku]

I can confirm this bug. Thanks for the report.

[gustavjf]

I think this might be a bug in diagram-js instead of bpmn-js.

Two newlines are inserted when pressing shift+enter in a contenteditable div, which are later parsed as <tspan> tags when pressing enter.

Before pressing enter:

After pressing enter:

Once those two characters have been inserted and the task is rendered as SVG after pressing enter, only one is removed on backspace when trying to edit again. This leaves a stray <tspan> in place, causing the unwanted space.

I thought of trimming whitespace before parsing as <tspan> tags here but I noticed two things:

1. A user will not see the rendered effect of inserting newlines without any text following it. This may or may not be desirable.

2. The text content of the contenteditable div and the result of the rendered SVG will not be in sync. The rendered SVG will not have trailing <tspan>s but the contenteditable div will retain the newline characters when going back to edit.

For what it's worth, trimming and thus preventing trailing whitespace from being rendered as SVG would also prevent the task's text from being rendered outside of the task itself:

Any thoughts? If the two points above aren't an issue, I could prepare a PR with the trim I mentioned.

[nikku]

My guess is that we must properly handle this issue in diagram-js-direct-editing.

One approach would be to make sure that the text is trimmed after editing, committing it without trailing and leading whitespace.

[gustavjf]

Makes sense, how about this?

[nikku]

Needs patch release of diagram-js.

[gustavjf]

Fixed via 0cfd960