Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop on flow should remove redundant incoming and outgoing sequence flows. #774

Closed
1 task
nikku opened this issue Mar 23, 2018 · 0 comments
Closed
1 task
Labels
enhancement New feature or request modeling ux

Comments

@nikku
Copy link
Member

nikku commented Mar 23, 2018

I'm considering a scenario where the Task to be dropped on a sequence flow already has incoming and outgoing sequenceflows.

Given our current way of dropping all incoming and outgoing flows are being kept. During execution this effectively duplicates the token (a Task with two outgoing sequenceflows is effectively an AND split. This is something one most likely does not want to achieve (cf. screencast below).

bug

In the presence of default flows or sequence flows with conditions the situation is slightly different, as these are not redundant / semantically equal.

Tasks

  • Remove redundant sequence flows when dropping on flow

Two sequence flows are redundant, if they connect the same source / target and (have the same condition or are both default flows).

@nikku nikku added ready Ready to be worked on backlog Queued in backlog and removed ready Ready to be worked on labels Apr 19, 2018
@nikku nikku added ready Ready to be worked on enhancement New feature or request in progress Currently worked on and removed backlog Queued in backlog ready Ready to be worked on labels Jul 20, 2018
nikku added a commit that referenced this issue Jul 24, 2018
This prevents duplicate flows from being created, accidentially.

Closes #774
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Jul 24, 2018
philippfromme pushed a commit that referenced this issue Jul 25, 2018
This prevents duplicate flows from being created, accidentially.

Closes #774
@ghost ghost removed the needs review Review pending label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modeling ux
Projects
None yet
Development

No branches or pull requests

1 participant