Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundary TimerEventDefinitions config lost when switching between interrupting and non-interrupting #799

Closed
nboissel opened this issue May 22, 2018 · 2 comments
Closed

Boundary TimerEventDefinitions config lost when switching between interrupting and non-interrupting #799

nboissel opened this issue May 22, 2018 · 2 comments
Assignees
@nikku

Comments

@nboissel
Copy link

Hello,

The title is quite self explanatory. Configuration of boundary timer is lost when switching between interrupting and non-interrupting as its configuration is embedded in a child element and not in attributes.

Boundary timers can keep their configuration since it's just a small change in behavior.

My PR is coming for this if you also consider this as an issue.
nboissel pushed a commit to nboissel/bpmn-js that referenced this issue May 22, 2018
feat(replace): Keep timer boundary config when just switching interrupt
48d49fa 
TimerEventDefinitions loose its configuration (which is a child element) when switching between interrupting and not interrupting.

Related to bpmn-io#799
@nboissel nboissel mentioned this issue May 22, 2018
Closed
@ghost ghost added the needs review Review pending label May 22, 2018
@nikku
Copy link
Member

nikku commented May 30, 2018

This is a more general issue.

Any boundary event that is replaced from interrupting to non-interrupting and vice versa loses its definitions.

nikku pushed a commit that referenced this issue Jun 27, 2018
@nikku
feat(replace): Keep timer boundary config when just switching interrupt
3c8a02d 
TimerEventDefinitions loose its configuration (which is a child element) when switching between interrupting and not interrupting.

Related to #799
nikku added a commit that referenced this issue Jun 27, 2018
@nikku
chore(replace): retain definitions where appropriate
c8db48a 
* simplify implementation
* retain event definitions when switching from interrupting
  to non-interrupting and vice versa

Related to #799
@nikku nikku mentioned this issue Jun 27, 2018
Merged
@ghost ghost assigned nikku Jun 27, 2018
nikku added a commit that referenced this issue Jun 27, 2018
@nikku
chore(replace): retain definitions where appropriate
48af4ea 
* simplify implementation
* retain event definitions when switching from interrupting
  to non-interrupting and vice versa

Closes #799
philippfromme pushed a commit that referenced this issue Jun 28, 2018
@nikku @philippfromme
chore(replace): retain definitions where appropriate
75c0880 
* simplify implementation
* retain event definitions when switching from interrupting
  to non-interrupting and vice versa

Closes #799
@ghost ghost removed the needs review Review pending label Jun 28, 2018
@nboissel
Copy link
Author

Thank you for this fix.

@sombrek sombrek mentioned this issue Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @nboissel