Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't combine source/target flows other than sequence flows on element deletion #917

Closed
1 task done
nikku opened this issue Nov 30, 2018 · 1 comment
Closed
1 task done

Don't combine source/target flows other than sequence flows on element deletion #917

nikku opened this issue Nov 30, 2018 · 1 comment
Assignees
@nikku
Labels
bug Something isn't working modeling

Comments

@nikku
Copy link
Member

nikku commented Nov 30, 2018 •
edited
Loading

Describe the Bug

The RemoveElementBehavior does not properly check, whether source and target are sequence flows, thus allowing the following to happen (which makes no sense):

foo

Expected Behavior

  • Combining of incoming / outgoing flows only happens if the source / target of the to be removed flow are sequence flows

Environment

  • Any (environment independent)
nikku added a commit that referenced this issue Nov 30, 2018
@nikku
fix(modeling): limit flow join behavior to bpmn:SequenceFlows
65ad36a 
Closes #917
@ghost ghost assigned nikku Nov 30, 2018
@ghost ghost added the in progress Currently worked on label Nov 30, 2018
@nikku nikku changed the title Don't sequence and message flows on element deletion Don't combine source/target flows other than sequence flows on element deletion Nov 30, 2018
This was referenced Nov 30, 2018
Closed
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Nov 30, 2018
@nikku nikku mentioned this issue Nov 30, 2018
Closed
3 tasks
merge-me bot pushed a commit that referenced this issue Nov 30, 2018
@nikku @merge-me
fix(modeling): limit flow join behavior to bpmn:SequenceFlows
7aad42d 
Closes #917
@nikku
Copy link
Member Author

nikku commented Nov 30, 2018

Closed via 7aad42d

@nikku nikku closed this as completed Nov 30, 2018
@ghost ghost removed the needs review Review pending label Nov 30, 2018
@nikku nikku added bug Something isn't working modeling labels Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working modeling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikku