Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isHorizontal=true to Participant / Lane DI shapes #934

Closed
2 tasks
nikku opened this issue Jan 22, 2019 · 1 comment
Closed
2 tasks

Add isHorizontal=true to Participant / Lane DI shapes #934

nikku opened this issue Jan 22, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request forgiveness miwg Tracks BPMN compatibility issues modeling

Comments

@nikku
Copy link
Member

nikku commented Jan 22, 2019

Is your feature request related to a problem? Please describe.

The isHorizontal attribute on participant and lane DI shapes is meta-data that helps editors to understand how these elements are laid out. Quoting from the BPMN spec (p. 373):

  • isHorizontal : Boolean [0..1]
    an optional attribute that should be used only for Pools and Lanes. It determines if it should be depicted horizontally (true) or vertically (false).

The attribute is not necessarily required, thus this feature request falls into the forgiveness / compatibility category.

Describe the solution you'd like

We should add the attributes, as we only support horizontal modeling anyway and "fix" existing diagrams by gradually introducing the

  • add isHorizontal=true on newly created participant / lane DI shapes
  • add isHorizontal=true on update participant / lane DI shapes

Describe alternatives you've considered

  • ignore compatibility concerns and keep things as is

Additional context

Reported in camunda/camunda-modeler#1096, too.

@nikku nikku added forgiveness miwg Tracks BPMN compatibility issues modeling enhancement New feature or request labels Jan 22, 2019
@nikku nikku added the ready Ready to be worked on label Jan 22, 2019
@ghost ghost assigned barmac Jan 23, 2019
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Jan 23, 2019
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 25, 2019
@barmac
Copy link
Member

barmac commented Jan 31, 2019

Closed via #936

@barmac barmac closed this as completed Jan 31, 2019
@ghost ghost removed the needs review Review pending label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forgiveness miwg Tracks BPMN compatibility issues modeling
Projects
None yet
Development

No branches or pull requests

2 participants