Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element order is not updated in BPMNDI #985

Closed
1 task
nikku opened this issue Apr 18, 2019 · 3 comments
Closed
1 task

Element order is not updated in BPMNDI #985

nikku opened this issue Apr 18, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request export miwg Tracks BPMN compatibility issues spring cleaning Could be cleaned up one day
Milestone

Comments

@nikku
Copy link
Member

nikku commented Apr 18, 2019

Describe the Bug

As mentioned in this comment the BPMN spec mandates that the order of elements in the BPMNDI section should always reflect the actual layering on the diagram.

We do ignore that fact completely and add elements to the BPMNDI section on a first created, first added basis. This results in display bugs when roundtripping with other, standards compliant tools.

Steps to Reproduce

Steps to reproduce the behavior:

  • Create a task
  • Create a sub process
  • Move task to sub process
  • Export Diagram
  • Task is exported before sub process in BPMNDI

Expected Behavior

  • Task position in DI is updated according to actual visibility

Note: This is not simple to accomplish, as we must effectively update all nested elements, too.

Environment

Please complete the following information:

  • Browser: Any (independent)
  • OS: Any (independent)
  • Library version: v3.3.1
@nikku
Copy link
Member Author

nikku commented Apr 18, 2019

Idea: If we cannot get the ordering done efficiently during modeling, build a pre-export extension that normalizes things before safe. We got a few utilities that go the same route, already.

@nikku nikku added backlog Queued in backlog enhancement New feature or request export miwg Tracks BPMN compatibility issues labels Apr 23, 2019
@nikku nikku added the spring cleaning Could be cleaned up one day label Feb 26, 2020
@barmac barmac self-assigned this Mar 12, 2020
@barmac barmac added in progress Currently worked on and removed backlog Queued in backlog labels Mar 13, 2020 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 13, 2020
@barmac barmac closed this as completed in 7696534 Mar 16, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 16, 2020
@falko
Copy link
Member

falko commented Mar 16, 2020

Awesome, thx!

@barmac
Copy link
Member

barmac commented Mar 16, 2020

Looking forward to your feedback! It's coming with the 3.7.1 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request export miwg Tracks BPMN compatibility issues spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants