Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redoing element removal does not restore exactly same waypoints #989

Closed
barmac opened this issue Apr 18, 2019 · 1 comment
Closed

Redoing element removal does not restore exactly same waypoints #989

barmac opened this issue Apr 18, 2019 · 1 comment
Assignees
@barmac
Labels
bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented Apr 18, 2019 •
edited
Loading

Describe the Bug

Waypoints restored via redo might be different than after original command. This happens on element removal.

Revealed in #988

Test case available in https://github.com/bpmn-io/bpmn-js/tree/989-correct-waypoints-restore-on-element-removal

Steps to Reproduce

removal

Steps to reproduce the behavior:

  1. Connect three elements positioned diagonally
  2. Remove the middle element
  3. Undo
  4. Redo

The connection has different waypoints than after removal.

Expected Behavior

Waypoints should be the same.

Environment

Please complete the following information:

  • Browser: Chrome
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@barmac barmac added bug Something isn't working ready Ready to be worked on labels Apr 18, 2019
@ghost ghost assigned barmac Apr 18, 2019
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Apr 18, 2019
@nikku nikku mentioned this issue Apr 18, 2019
Closed
3 tasks
@nikku
Copy link
Member

nikku commented Apr 18, 2019

Most likely related to this comment.

nikku added a commit that referenced this issue Apr 18, 2019
@nikku
test(modeling): verify consisten connection layouting on element removal
b377b97 
Closes #989
merge-me bot pushed a commit that referenced this issue Apr 18, 2019
@nikku @merge-me
test(modeling): verify consisten connection layouting on element removal
b72bdf2 
Closes #989
@nikku nikku closed this as completed in a40b95c Apr 18, 2019
@ghost ghost removed the in progress Currently worked on label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @barmac