-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly lay out boundary to activity loops #1070
Merged
nikku
merged 5 commits into
master
from
903-correctly-lay-out-boundary-to-activity-loops
Jun 12, 2019
Merged
Correctly lay out boundary to activity loops #1070
nikku
merged 5 commits into
master
from
903-correctly-lay-out-boundary-to-activity-loops
Jun 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested changes
Jun 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikku
force-pushed
the
903-correctly-lay-out-boundary-to-activity-loops
branch
from
June 7, 2019 08:46
ef58a0f
to
4c30193
Compare
We discussed this and agreed on looking into the connection behavior with sub-processes, too. |
barmac
changed the title
Correctly lay out boundary to activity loops
WIP Correctly lay out boundary to activity loops
Jun 7, 2019
nikku
added
in progress
Currently worked on
and removed
needs review
Review pending
labels
Jun 12, 2019
— with
bpmn-io-tasks
barmac
force-pushed
the
903-correctly-lay-out-boundary-to-activity-loops
branch
2 times, most recently
from
June 12, 2019 15:02
0269873
to
1f49652
Compare
Loops will now be laid out with respect to minimum second segment width.
barmac
force-pushed
the
903-correctly-lay-out-boundary-to-activity-loops
branch
from
June 12, 2019 15:06
1f49652
to
e17b433
Compare
It's not WIP anymore. @nikku can you please have a look at this once more? Summary of changes:
|
barmac
changed the title
WIP Correctly lay out boundary to activity loops
Correctly lay out boundary to activity loops
Jun 12, 2019
delete-merged-branch
bot
deleted the
903-correctly-lay-out-boundary-to-activity-loops
branch
June 12, 2019 18:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Required by camunda/camunda-modeler#903
See screenshots in the linked issue for the context.