Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly lay out boundary to activity loops #1070

Merged
merged 5 commits into from
Jun 12, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 6, 2019

Summary of changes:

  • we no longer snap to target center during connection
  • we snap inside of the target element
  • we snap Boundary Event loops in the way to make sure the connection end is not too close
  • layouter checks the area where cursor is placed to determine loop layout hints

Required by camunda/camunda-modeler#903

See screenshots in the linked issue for the context.

@barmac barmac requested a review from philippfromme June 6, 2019 13:07
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 6, 2019
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the behavior for tasks (with a specified size).

However, it does not seem to be the right behavior for sub-processes:

foo

@nikku nikku force-pushed the 903-correctly-lay-out-boundary-to-activity-loops branch from ef58a0f to 4c30193 Compare June 7, 2019 08:46
@nikku
Copy link
Member

nikku commented Jun 7, 2019

We discussed this and agreed on looking into the connection behavior with sub-processes, too.

@barmac barmac changed the title Correctly lay out boundary to activity loops WIP Correctly lay out boundary to activity loops Jun 7, 2019
@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Jun 12, 2019 — with bpmn-io-tasks
@barmac barmac force-pushed the 903-correctly-lay-out-boundary-to-activity-loops branch 2 times, most recently from 0269873 to 1f49652 Compare June 12, 2019 15:02
@barmac barmac force-pushed the 903-correctly-lay-out-boundary-to-activity-loops branch from 1f49652 to e17b433 Compare June 12, 2019 15:06
@barmac
Copy link
Member Author

barmac commented Jun 12, 2019

It's not WIP anymore. @nikku can you please have a look at this once more?

Summary of changes:

  • we no longer snap to target center during connection
  • we snap inside of the target element
  • we snap Boundary Event loops in the way to make sure the connection end is not too close
  • layouter checks the area where cursor is placed to determine loop layout hints

@barmac barmac changed the title WIP Correctly lay out boundary to activity loops Correctly lay out boundary to activity loops Jun 12, 2019
@nikku nikku merged commit a09e0a3 into master Jun 12, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Jun 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the 903-correctly-lay-out-boundary-to-activity-loops branch June 12, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants