Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve navigation inside large participants #1097

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Improve navigation inside large participants #1097

merged 3 commits into from
Jun 25, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 20, 2019 •
edited
Loading

@barmac barmac requested a review from nikku June 20, 2019 14:37
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 20, 2019
@nikku
Copy link
Member

nikku commented Jun 20, 2019

Does this cover sub-processes, too? We must include these, as they can be huge container elements, too.

@barmac
Copy link
Member Author

barmac commented Jun 21, 2019

No, I will cover this then.

@barmac
Copy link
Member Author

barmac commented Jun 21, 2019

So I tried the easy way and ended up with an infinite loop 😆
loop

@barmac
Copy link
Member Author

barmac commented Jun 21, 2019

Note for myself: I discovered that at some point SubProcess becomes a child of itself. Then, the recursive search destroys everything.

@barmac barmac force-pushed the 238-participant-navigation branch from b2a971a to 2efb1f4 Compare June 21, 2019 12:49
@barmac
Copy link
Member Author

barmac commented Jun 21, 2019

Just pushed a working demo. It needs dynamic tests too, though. Notice change in diagram-js which occured to be required for the progress.

@barmac barmac force-pushed the 238-participant-navigation branch 2 times, most recently from df0cfff to 816c646 Compare June 21, 2019 16:41
@barmac
Copy link
Member Author

barmac commented Jun 22, 2019

This requires more work as we currently treat equally expanded and collapsed elements which should not take place.

@barmac
Copy link
Member Author

barmac commented Jun 22, 2019 •
edited
Loading

However, the ugly indefinite loops bugs are already fixed with recent commits :)

@barmac barmac changed the title Improve navigation inside large participants WIP Improve navigation inside large participants Jun 22, 2019
@barmac barmac force-pushed the 238-participant-navigation branch from 36d2d4d to a0cf3a4 Compare June 24, 2019 09:31
@barmac barmac changed the title WIP Improve navigation inside large participants Improve navigation inside large participants Jun 24, 2019
@barmac
Copy link
Member Author

barmac commented Jun 24, 2019

@nikku I added collapsed shape support so this is ready for review.

@barmac barmac force-pushed the 238-participant-navigation branch from a0cf3a4 to e4cdd37 Compare June 24, 2019 09:35
@barmac
Copy link
Member Author

barmac commented Jun 24, 2019

Apparently this seems to close #957

@nikku
Copy link
Member

nikku commented Jun 24, 2019

Apparently this seems to close #957

Apparently 😉

@nikku nikku force-pushed the 238-participant-navigation branch 3 times, most recently from c07294c to 9b82459 Compare June 25, 2019 15:59
nikku and others added 3 commits June 25, 2019 18:01
@nikku
chore(project): bump diagram-js version
9e8a84f
@philippfromme @nikku
feat(modeling): prevent accidential dragging of container elements
7b0e304 
This implements custom hit areas for participants, lanes and
expanded subprocesses.

Given these changes, users need to grab container elements
on the boarder or the label area to move them.

Closes #957
@nikku
feat(modeling): allow to drag participant via nested lane
fdb299d 
Related to #957
@nikku nikku force-pushed the 238-participant-navigation branch from 9b82459 to fdb299d Compare June 25, 2019 16:01
@nikku nikku merged commit fdb299d into master Jun 25, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the 238-participant-navigation branch June 25, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku Awaiting requested review from nikku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve navigation in container elements
3 participants
@barmac @nikku @philippfromme