Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copy-paste): copy error, escalation, message and signal references #1245

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Nov 21, 2019

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 21, 2019
@philippfromme philippfromme force-pushed the 1463-root-element-reference-fix branch from 503458a to e4149b9 Compare November 21, 2019 08:14
@nikku
Copy link
Member

nikku commented Nov 27, 2019

What is the status here? Can I review it?

@philippfromme philippfromme force-pushed the 1463-root-element-reference-fix branch from e4149b9 to 64a37da Compare November 27, 2019 14:24
@philippfromme philippfromme marked this pull request as ready for review November 27, 2019 15:21
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 27, 2019
@philippfromme philippfromme requested a review from nikku November 27, 2019 15:21
@philippfromme
Copy link
Contributor Author

@nikku It's ready.

@philippfromme
Copy link
Contributor Author

One possible improvement would be to remove references to root elements when they're deleted, even though that's not possible at the moment. It would allow us to add the ability to remove root elements to the properties panel without worrying about other elements referencing them.

@philippfromme
Copy link
Contributor Author

  • remove referenced root element once it's not referenced anymore

We decided to not automatically remove root elements.

@nikku
Copy link
Member

nikku commented Nov 28, 2019

I user tested it. Works mostly already:

  • Copy on existing diagram keeps message ref
  • Copy across to a different diagram keeps message ref
  • Copy to different diagram with message non-existing => creates message

What does not yet work (maybe this is a separate feature request):

  • When changing a throwing message event to a catching message intermediate event => Message ref is dropped. Expected => Message ref remains valid and is copied/moved across. This applies for errors, signals, ... too.

@philippfromme
Copy link
Contributor Author

@nikku Shall I continue to work on this?

@nikku
Copy link
Member

nikku commented Nov 28, 2019

Let's complete this bug fix with the following feature set:

@philippfromme philippfromme force-pushed the 1463-root-element-reference-fix branch 2 times, most recently from 92e1d0b to ed5a7d8 Compare November 28, 2019 14:59
@philippfromme
Copy link
Contributor Author

@nikku Ready!

* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
@philippfromme
Copy link
Contributor Author

🎉

@falko
Copy link
Member

falko commented Dec 4, 2019

Great thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants