fix: empty whitespaces label in group

[abdul99ahad]

Closes #2231

Proposed Changes

• Enter whitespaces in group labels doesn't crash modeler
• Whitespaces will be treated as no label

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[nikku]

Watch for the contract of this function. If you early return, I propose you return element to not break it.

Alternative:

if (semantic[attr]) {
  // do change
}

My follow-up question is: Who calls this, and why, after the label has been removed? Will it ever be called with a non-empty text (in which case the above code would shadow a deeper issue?

Safe choice would be to be strict (ignore update only, if label is empty and categoryValueRef is unset).

[abdul99ahad]

I would agree to early return the element.

The updateLabel event calls this method. Even if we remove the existing label, it is updated via this method. It is not called after the label is removed, but rather when we are updating the label during execute lifecycle.

[abdul99ahad]

If the text is not empty, the label.create event will be fired and setCategoryValue function will be invoked in file GroupBehavior.js. So, in case the label is not empty, we will have categoryValueRef.