feat(labels): labels can be deleted #791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
philippfromme
force-pushed
the
243-delete-labels
branch
2 times, most recently
from
cf61cce to
d9b3d7c
Compare
nikku
reviewed
May 16, 2018
There was a problem hiding this comment.
What is our plan regarding copy and paste now? As indicated in a previous discussion it is broken?
My guess is you should create issues for the things that we still need to refactor to complete this ticket. Or is it broken in a sense that it is still somewhat usable and no change is required?
|
I think we should merge this for now and create an issue for copy & paste regarding business objects being mutated after copying. Rest looks fine to me. |
|
Please create the issue then and add link a failing test case. This will help us to continue the discussion / implementation from there. |
* due to LabelBehavior#97 and the known issue with copying business objects by reference this test fails
|
Closed via 7537757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related to camunda/camunda-modeler#243