Editor action refactoring #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
With the new version of `diagram-js`, the keyboard listeners receive a single parameter which is an object with `KeyboardEvent` event as the only property. `BpmnKeyBindings` needed to change in order to make use of new version of API.
`KeyboardEvent.keyCode` is deprecated, so the BpmnKeyBindings will use non-deprecated `KeyboardEvent.key` instead.
* Treat features as optional dependencies and register action only if feature exists * Explicitly add features to the Modeler and NavigatedViewer types
* only register keyboard bindings that are backed by actual editor actions * rename BpmnKeyBindings -> BpmnKeyboardBindings for parity with diagram-js@latest * sub-class and override _keyboardBindings_ service provided by diagram-js * extend spec to verify default actions
* event got renamed to keyEvent in context passed to keyboard listeners
barmac
force-pushed
the
editor-action-refactoring
branch
from
8d8d2a8 to
eadef0d
Compare
|
Added |
This was referenced Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon bpmn-io/diagram-js#295.
Refactors the editor actions to be independent from actual editor (or viewer) features, as discussed with @barmac.
Core features:
NavigatedViewerandModelerThis superseeds #886, if merged.