1344 Integrate Grid Snapping - Part 1 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
nikku
force-pushed
the
1344-integrate-grid-snapping
branch
from
e7882af to
773480c
Compare
nikku
requested changes
Apr 23, 2019
There was a problem hiding this comment.
I've tried the overall grid snapping experience on a real world, not-yet-snapped diagram and have some thoughts. Bottom line is that we should consider to keep the original position of elements / bendpoints / connection segments as a high priority snap point or annoying things happen (#993).
Other than that this implementation looks good.
|
Snap to self is one of the next issues I'll tackle. |
nikku
force-pushed
the
1344-integrate-grid-snapping
branch
from
773480c to
40a7a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bpmn-io/diagram-js#319
Related to camunda/camunda-modeler#1344
Related to camunda/camunda-modeler#1348
Related to camunda/camunda-modeler#1349