Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util/Text): make text-layouting lineHeight aware #256

Merged
merged 4 commits into from
May 29, 2018

Conversation

nikku
Copy link
Member

@nikku nikku commented May 28, 2018

This ensures we properly align text and support a numeric lineHeight property.

@ghost ghost assigned nikku May 28, 2018
@ghost ghost added the needs review Review pending label May 28, 2018
@nikku nikku force-pushed the text-layout-line-height branch from 5b49b6e to 63f3af9 Compare May 28, 2018 12:46
@nikku nikku force-pushed the text-layout-line-height branch from 63f3af9 to a22a17d Compare May 28, 2018 12:59
@nikku nikku requested a review from philippfromme May 28, 2018 13:36
@nikku nikku removed the request for review from philippfromme May 28, 2018 13:57
@nikku
Copy link
Member Author

nikku commented May 28, 2018

Need to improve external label rendering...

@nikku nikku force-pushed the text-layout-line-height branch 2 times, most recently from 4e3c0af to 33d8210 Compare May 29, 2018 09:36
@nikku nikku force-pushed the text-layout-line-height branch from 33d8210 to 87b3680 Compare May 29, 2018 09:47
@nikku nikku requested a review from philippfromme May 29, 2018 09:49
@philippfromme philippfromme merged commit 87b3680 into master May 29, 2018
@ghost ghost removed the needs review Review pending label May 29, 2018
@philippfromme philippfromme deleted the text-layout-line-height branch May 29, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants