Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape text shown in search pad #362

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Escape text shown in search pad #362

merged 3 commits into from
Jun 13, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Jun 12, 2019

No description provided.

nikku added 3 commits June 12, 2019 13:58
@nikku
chore(util): add reusable escape util
b52aa54
@nikku
fix(search-pad): prevent HTML injection
3c17ae4 
Given the apprioritate title and search text HTML injection was
possible until now.
@nikku
test(search-pad): verify HTML escaping
c8650d2
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 12, 2019
@nikku nikku requested a review from philippfromme June 12, 2019 13:16
philippfromme
philippfromme reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@philippfromme philippfromme merged commit bfeeeab into master Jun 13, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the search-prevent-html-injection branch June 13, 2019 07:34
@nikku
Copy link
Member Author

nikku commented Jun 13, 2019

Backported to:

  • 2.x
  • 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @philippfromme