fix: make name change behavior not break on name change

[barmac]

Proposed Changes

Screen.Recording.2024-11-08.at.10.24.04.mov

We've tested the label update but not the direct name change with modeling.updateProperties. Now we test for both.

Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[barmac]

After a second look at the name change behavior, I am not super happy about having two components doing the same thing (boxed expression and shared). However, for this fix I decided to only make a small change to avoid a potential bug.

[barmac]

Once merged, this will be released as 16.8.2

[nikku]

We missed updating the name attribute via modeling APIs and I see this is now covered.

Relevant follow-up: Will it break if we update moddle properties?

[barmac]

We missed updating the name attribute via modeling APIs and I see this is now covered.

Relevant follow-up: Will it break if we update moddle properties?

Hmm I think it will just not trigger. We could add it too.

[barmac]

But I'd do it in a separate PR. Ignoring an update is not breaking the editor.

[barmac]

Published as v16.8.2

[barmac]

Hmm this job should not have run at all: https://github.com/bpmn-io/dmn-js/actions/runs/11739770879
We need to fix it later on.

[nikku]

I think it would be reasonable to check for @latest tag and if that does not exist (because a release is a backport) the job is fine to fail.

By the way, your release broke latest, it is now back to 16.x, cf. npm.

[barmac]

Thanks for notice! I'll fix that

[barmac]

This will be fixed via v17.0.1 release.

[barmac]

Hmm I can't release it because tests fail due to f402e25. I will have a look again after lunch.

[barmac]

As a temporary fix, I fixed the latest for dmn-js. The subpackages will be fixed with the v17.0.1

[barmac]

So the test is now broken although its expects are logical. I debugged the test case, and while we set incorrect classes in the code, the actual position of the simple mode button is correct (top-right but with .bottom.right classes).

[barmac]

BTW the classes are not used for anything apart from the assertions, so we could as well remove them. I will double-check.