feat: remove feel input reziser #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
requested review from
nikku,
a team and
barmac
and removed request for
a team
nikku
reviewed
Jan 24, 2024
nikku
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Tested it and it works.
One minor thing you could consider: https://github.com/bpmn-io/properties-panel/pull/332/files#r1464546987
One additional thing I found is that the popup editor toggle is being pushed down by big contents, leaving folks unable to open it 🙈
I believe that one could be a nice follow-up fix.
smbea
force-pushed
the
remove-feel-resizer
branch
from
b8ef649 to
b5c9ff2
Compare
|
I updated with your suggestion. It works without but I guess this is safer.
So it should stay at the top instead for visibility? |
Yes. |
nikku
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#3895
Since the input is auto-resized, FEEL popup editor can be opened to see it better and the FEEL icon is getting in the way of the resizer, i followed the issues' suggestion and removed it.