Apply suggestions from code review

add additional change requests Co-authored-by: FR-SON <93994888+FR-SON@users.noreply.github.com>
bptlab · May 24, 2024 · c227dfb · c227dfb
1 parent d03b91d
commit c227dfb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/tracex_project/extraction/logic/modules/module_activity_labeler.py b/tracex_project/extraction/logic/modules/module_activity_labeler.py
@@ -73,7 +73,7 @@ def __extract_activities(patient_journey_numbered: str, condition: Optional[str]
         column_name = "activity"
         messages = Prompt.objects.get(name="TEXT_TO_ACTIVITY_MESSAGES").text
 
-        user_message = patient_journey_numbered
+        user_message: List[str] = patient_journey_numbered
         if condition is not None:
             user_message = f"Focus on those events that are related to the course of the disease of {condition}.\n\n\
             {user_message}"

diff --git a/tracex_project/extraction/logic/modules/module_time_extractor.py b/tracex_project/extraction/logic/modules/module_time_extractor.py
@@ -118,7 +118,7 @@ def fill_missing_values(df: pd.DataFrame, column: pd.Series):
 
             return df
 
-        def fix_end_dates(row):
+        def fix_end_dates(row: pd.Series) -> pd.Series:
             if (
                 row["time:end_timestamp"] is pd.NaT
                 and row["time:timestamp"] is not pd.NaT

diff --git a/tracex_project/extraction/logic/orchestrator.py b/tracex_project/extraction/logic/orchestrator.py
@@ -239,7 +239,7 @@ def save_results_to_db(self) -> None:
             events_with_metric_list.append(event)
             metric_list.append(metric)
 
-        events: list[Event] = Event.manager.bulk_create(events_with_metric_list)
+        events: List[Event] = Event.manager.bulk_create(events_with_metric_list)
         for event, metric in zip(events, metric_list):
             metric.event = event
         Metric.manager.bulk_create(metric_list)

diff --git a/tracex_project/extraction/views.py b/tracex_project/extraction/views.py
@@ -237,7 +237,7 @@ def get_context_data(self, **kwargs):
 
         context = super().get_context_data(**kwargs)
         orchestrator = Orchestrator.get_instance()
-        activity_key = orchestrator.get_configuration().activity_key
+        activity_key: str = orchestrator.get_configuration().activity_key
         filter_dict = {
             "event_type": orchestrator.get_configuration().event_types,
             "attribute_location": orchestrator.get_configuration().locations,
@@ -276,7 +276,7 @@ def get_context_data(self, **kwargs):
     @staticmethod
     def build_trace_df(filter_dict: Dict[str, List[str]]) -> pd.DataFrame:
         """Build the trace dataframe based on the filter settings."""
-        trace_df = Orchestrator.get_instance().get_data()
+        trace_df: pd.DataFrame = Orchestrator.get_instance().get_data()
         trace_df_filtered = utils.DataFrameUtilities.filter_dataframe(
             trace_df, filter_dict
         )