Add reversible participant creation #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be create, e.g., when dragging a task from the pallet, or by creating a new participant from the context menu, but not removed when reverting that action. This is fixed by wrapping the createParticipant function from BandUtil.js with a Command in ChoreoParticipantHandler.js which in turn is also wrapped by ChoreoModeling.js for usability.
yT0n1
changed the title
yT0n1
changed the title
jan-ladleif
approved these changes
Oct 29, 2020
jan-ladleif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #142.
Fixes an issue where the participant business object would be created, e.g., when dragging a task from the pallet, or by creating a new participant from the context menu, but not removed when reverting that action.
This is fixed by wrapping the #createParticipant function from BandUtil.js with a Command in ('participant.create') ChoreoParticipantHandler.js which in turn is also wrapped by ChoreoModeling.js with #createParticipant for usability.