Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin and test Poetry version #6

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Pin and test Poetry version #6

merged 1 commit into from
Oct 23, 2021

Conversation

br3ndonland
Copy link
Owner

@br3ndonland br3ndonland commented Oct 23, 2021

Description

Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this PR will implement installation and testing of specific versions of Poetry, rather than the latest version.

Changes

The following steps will be taken to install Poetry and verify that the correct version is installed:

  1. Set the PIPX_VERSION and POETRY_VERSION environment variables, which will be used to install specific versions of each package
  2. Install pipx with pip, for the appropriate version of Python (pipx is included by default in the GitHub Actions virtual environment, but only for the default Python version, not necessarily the version installed by actions/setup-python)
  3. Install Poetry with pipx, instead of the get-poetry.py and install-poetry.py install scripts
  4. Run a shell test to assert that the Poetry version returned by the poetry -V command matches POETRY_VERSION

Related

Poetry has introduced a number of problematic changes recently. To help
buffer against these problematic changes, this commit will implement
installation and testing of specific versions of Poetry, rather than the
latest version.

The following steps will be taken to install Poetry and verify that the
correct version is installed:

1. Set the `PIPX_VERSION` and `POETRY_VERSION` environment variables,
   which will be used to install specific versions of each package
2. Install `pipx` with `pip`, for the appropriate version of Python:
   `pipx` is included by default in the GitHub Actions virtual
   environment, but only for the default Python version, not necessarily
   the version installed by actions/setup-python
3. Install Poetry with `pipx`, instead of the get-poetry.py or
   install-poetry.py install scripts
4. Run a shell test to assert that the Poetry version returned by the
   `poetry -V` command matches `POETRY_VERSION`
@vercel
Copy link

vercel bot commented Oct 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/br3ndonland/fastenv/4Szn8LCBdmf7i6XJzjfSHE664Uqn
✅ Preview: https://fastenv-git-poetry-version-br3ndonland.vercel.app

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #6 (ed7c8d2) into develop (47065f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #6   +/-   ##
========================================
  Coverage    100.0%   100.0%           
========================================
  Files            3        3           
  Lines          122      122           
========================================
  Hits           122      122           
Flag Coverage Δ
unit 100.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47065f8...ed7c8d2. Read the comment docs.

@br3ndonland br3ndonland merged commit b9d417b into develop Oct 23, 2021
@br3ndonland br3ndonland deleted the poetry-version branch October 23, 2021 21:11
br3ndonland added a commit to br3ndonland/template-python that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant