Integrate with object storage (Sourcery refactored) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/br3ndonland/fastenv/4qBTSGYYyLP6ZcSUiZc2c4TZ5XAb |
The dictionary union operator was introduced in Python 3.9. This project still supports Python 3.8. Attempting to use the union operator on Python 3.8 will result in errors, as seen in the failed mypy check on this PR. https://docs.python.org/3/whatsnew/3.9.html https://docs.sourcery.ai/refactorings/use-dictionary-union/
br3ndonland
approved these changes
Apr 9, 2022
There was a problem hiding this comment.
The use-dictionary-union refactoring is not appropriate for this project. The dictionary union operator was introduced in Python 3.9. This project still supports Python 3.8. Attempting to use the union operator on Python 3.8 will result in errors, as seen in the failed mypy check on this PR.
Commit 461a2f4 reverted the use-dictionary-union suggestions. The PR is now okay to merge.
br3ndonland
pushed a commit
that referenced
this pull request
Apr 9, 2022
* 'Refactored by Sourcery' * Reject Sourcery `use-dictionary-union` refactoring The dictionary union operator was introduced in Python 3.9. This project still supports Python 3.8. Attempting to use the union operator on Python 3.8 will result in errors, as seen in the failed mypy check on this PR. https://docs.python.org/3/whatsnew/3.9.html https://docs.sourcery.ai/refactorings/use-dictionary-union/
This was referenced Apr 9, 2022
br3ndonland
added a commit
that referenced
this pull request
Apr 11, 2022
#9 (review) sourcery-ai/sourcery#223 https://docs.sourcery.ai/Configuration/ May be able to move this into pyproject.toml: sourcery-ai/sourcery#159
br3ndonland
added a commit
to br3ndonland/inboard
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #8 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
object-storagebranch, then run:Help us improve this pull request!